Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run build before and during interactive mocha #7651

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

maribethb
Copy link
Contributor

The basics

The details

Resolves

Fixes annoyance where if you modify blockly while trying to debug tests, you

  1. run npm run test:mocha:interative to run the tests
  2. make a change in blockly itself
  3. kill the mocha server (or switch to a new terminal tab)
  4. rebuild blockly
  5. restart mocha server

I always forget that I have to rebuild blockly so I end up thinking my tests pass when they don't or vice versa

Proposed Changes

  • Runs npm run build before launching tests, and uses concurrently and tsc watch to also rebuild on changes to core, just like we do for the playground.
  • Now you just need to wait for blockly to rebuild and then refresh the mocha page

Reason for Changes

i was annoyed while writing tests

Test Coverage

no

Documentation

no

Additional Information

@maribethb maribethb requested a review from cpcallen November 15, 2023 20:00
@maribethb maribethb requested a review from a team as a code owner November 15, 2023 20:00
@github-actions github-actions bot added the PR: chore General chores (dependencies, typos, etc) label Nov 15, 2023
@maribethb maribethb merged commit bf91422 into google:develop Nov 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants