fix: prevent crash when clicking on a field to delete a block #7621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apoorvgarg-creator
changed the title
Apoorvgarg-creator
changed the title
BeksOmega
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Heya @Apoorvgarg-creator Thank you for your work on this :D
I gave it a look and I /think/ we can move the isDeadOrDying check out of the loop, so that it's at the top of the function. Can you give that a try for me and tell me if it works?
core/block_svg.ts
Outdated
Comment on lines
1187
to
1188
| const isDeadOrDying: boolean = block.isDeadOrDying(); | ||
| if (isDeadOrDying) { |
There was a problem hiding this comment.
If you're immediately checking it, there's no need to store the value in a temp variable!
Suggested change
| const isDeadOrDying: boolean = block.isDeadOrDying(); | |
| if (isDeadOrDying) { | |
| if (block.isDeadOrDying()) { |
BeksOmega
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
This looks great! Thank you for the fix @Apoorvgarg-creator =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7587
Proposed Changes
The change is to check if the block is dead or is in dying state before accessing it in the
bringToFrontfunction.Reason for Changes
Test Coverage
Documentation
Additional Information