fix: adding and removing css classes that contained spaces #6455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6454
Proposed Changes
Adds proper splitting to addClass and removeClass. Changes everything back to using addClass and removeClass
Behavior Before Change
We had things in core that implicitly supported applying multiple classes separated by spaces, which recently broke.
Behavior After Change
Now it is working once again.
Reason for Changes
Regressions are sad.
Test Coverage
Added a test specifically for applying multiple classes to an icon, cuz it was easy. But generally I'm just trusting that my fixes are correct.
Documentation
N/A
Additional Information
N/A