fix: Fix errors in TS declarations with blocks and generators #6200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6079.
Proposed Changes
This is a cherry-pick of #6174 and #6185
Behavior Before Change
Errors when using Blockly v8 with TypeScript (see issue)
Behavior After Change
There are still problems with the TypeScript declarations, but they can be worked around by casting to
any. For example, you may see a TypeError related to the injection of BlocklyOptions inBlockly.inject. If so, you can avoid that by casting that parameter toanyto bypass the type error.This is in contrast with the current behavior which throws an error that cannot be avoided by casting.
Reason for Changes
Test Coverage
Documentation
Additional Information
See original PRs for more information about testing and background.