fix: update extraState property in serializer typedefs

[maribethb]

The basics

• I branched from develop
• My pull request is against develop
• My code follows the style guide
• I ran npm run format and npm run lint

The details

Resolves

In the JSON serializer there are two typedefs with a property called extra-state. This breaks the hell out of the typescript definitions because the compiler can't parse the jsdoc. e.g. the early commits here #6051 (and also last quarter had to be hand-fixed)

Proposed Changes

Adds quotations around the property. Properties with dashes can only be accessed with bracket notation and quotes, so adding the quotes helps the TypeScript parser.

I think this property probably should have been called extraState from the beginning. Is it worth changing now? It's probably somewhat annoying for an external developer because they have to use bracket notation. If we were to change it then asap would be better. We could probably handle both values in the serializer to avoid making that a breaking change? Not sure if it's worth it, would like your input Beka.

Behavior Before Change

Behavior After Change

Reason for Changes

Test Coverage

Tested this fixes the TypeScript definition generation problems; the output is no longer malformed with this change.

Documentation

Additional Information

[BeksOmega]

I checked and that property is actually incorrect haha. It should be extraState, because that is what is actually being used by the serializer. Thanks for the catch!