Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): Add a test to validate scripts/migration/renamings.js #5980

Merged
merged 17 commits into from
Mar 9, 2022
Merged

feat(tests): Add a test to validate scripts/migration/renamings.js #5980

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c0ae396
feat(tests): Add a test script for the renamings file
cpcallen Mar 4, 2022
b2ff483
fix: convert to JSON5 and refactor example
BeksOmega Mar 4, 2022
8f17dd2
fix: convert keys to new key names
BeksOmega Mar 4, 2022
405262c
fix: change versions to arrays instead of objects
BeksOmega Mar 4, 2022
032802b
fix: fix version numbers
BeksOmega Mar 4, 2022
dc08c2a
fix: associate renames with the version where they were added
BeksOmega Mar 4, 2022
e9a9c80
fix: fixup example
BeksOmega Mar 4, 2022
efe070e
fix: put older renames at the bottom, and newer renames at the top
BeksOmega Mar 4, 2022
2ce6872
fix: enable renamings test in run_all_tests
BeksOmega Mar 4, 2022
bb48255
fix: put newer renames back at the bottom
cpcallen Mar 7, 2022
066487d
fix(tests): add missing additionalProperties: false to schema
cpcallen Mar 7, 2022
c7c1450
chore(tests): Improve wording of example entry; add extra examples
cpcallen Mar 7, 2022
485706e
feat: add dropDownDiv renaming to new database
BeksOmega Mar 7, 2022
9b60aad
feat(tests): Check for duplicate entries for the same module
cpcallen Mar 7, 2022
cd79426
Merge branch 'develop' into validate-renamings
cpcallen Mar 8, 2022
f5a1e8c
fix(tests): Make validate-renamings.js compatible with node.js v12
cpcallen Mar 8, 2022
6327077
fix(tests): Fixes for PR #5980
cpcallen Mar 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/migration/renamings.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@
oldName: 'Blockly.blocks.variablesDynamic',
newName: 'Blockly.libraryBlocks.variablesDynamic',
},
]
],

'7.20211209.0': [
{
Expand Down
2 changes: 2 additions & 0 deletions tests/migration/validate-renamings → tests/migration/validate-renamings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
* (renamings-schema.json).
*/

/* global require __dirname process */
cpcallen marked this conversation as resolved.
Show resolved Hide resolved

const JsonSchema = require('@hyperjump/json-schema');
const JSON5 = require('json5');
const fs = require('fs/promises');
Expand Down
4 changes: 4 additions & 0 deletions tests/run_all_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,9 @@ run_test_command "build-debug" "npm run build-debug"
# TODO(5621): Re-enable this test once typings generation is fixed.
# run_test_command "typings" "npm run typings"

# Run renaming validation test.
run_test_command "renamings" "tests/migration/validate-renamings.js"

# Check the sizes of built files for unexpected growth.
run_test_command "metadata" "tests/scripts/check_metadata.sh"

Expand All @@ -77,6 +80,7 @@ run_test_command "package" "npm run package"
# Run Node tests.
run_test_command "node" "./node_modules/.bin/mocha tests/node --config tests/node/.mocharc.js"


BeksOmega marked this conversation as resolved.
Show resolved Hide resolved
# Attempt advanced compilation of a Blockly app.
run_test_command "advanced_compile" "npm run test:compile:advanced"

Expand Down