Bump google-closure-compiler from 20210601.0.0 to 20211006.0.0

core/registry.js

@@ -41,7 +41,7 @@ const Theme = goog.requireType('Blockly.Theme');
 /* eslint-disable-next-line no-unused-vars */
 const ToolboxItem = goog.requireType('Blockly.ToolboxItem');
 /* eslint-disable-next-line no-unused-vars */
-const ISerializer = goog.requireType('Blockly.serialization.ISerializer');
+const {ISerializer} = goog.requireType('Blockly.serialization.ISerializer');
 /* eslint-disable-next-line no-unused-vars */
 const {Cursor} = goog.requireType('Blockly.Cursor');
 

externs/goog-externs.js

@@ -5,11 +5,62 @@
  */
 
 /**
- * @fileoverview Externs for goog.
+ * @fileoverview Externs for goog.*
+ *
+ * These are needed because we use goog.module, goog.require etc. to
+ * define our modules, but we don't actually include
+ * closure/goog/base.js as input to the compiler.  Originally we only
+ * needed the extern for goog, but some time between Closure Compiler
+ * versions 20210601.0.0 and 20211006.0.0 we started getting
+ * JSC_POSSIBLE_INEXISTENT_PROPERTY errors for goog.module /
+ * goog.require / goog.requireType declarations involving modules
+ * which used goog.module.declareLegacyNamespace.
+ *
  * @externs
  */
 
 /**
  * @type {!Object}
  */
 var goog = {};
+
+/**
+ * @param {string} name
+ * @return {void}
+ */
+goog.module = function(name) {};
+
+/**
+ * @return{void}
+ */
+goog.module.declareLegacyNamespace = function() {};
+
+/**
+ * @param {string} name
+ * @return {?}
+ */
+goog.module.get = function(name) {};
+
+/**
+ * @param {string} name
+ * @return {void}
+ */
+goog.provide = function(name) {};
+
+/**
+ * @param {string} namespace
+ * @return {?}
+ */
+goog.require = function(namespace) {};
+
+/**
+ * @param {string} namespace
+ * @return {?}
+ */
+goog.requireType = function(namespace) {};
+
+/**
+ * @param {string=} opt_message
+ * @return{void}
+ */
+goog.setTestOnly = function(opt_message) {};

package.json

@@ -75,7 +75,7 @@
     "clang-format": "^1.5.0",
     "concurrently": "^6.0.0",
     "eslint": "^7.28.0",
-    "google-closure-compiler": "^20210601.0.0",
+    "google-closure-compiler": "^20211006.0.0",
     "google-closure-deps": "^20210601.0.0",
     "gulp": "^4.0.2",
     "gulp-concat": "^2.6.1",

scripts/gulpfiles/build_tasks.js

@@ -91,7 +91,6 @@ var JSCOMP_ERROR = [
   // 'strictPrimitiveOperators',
   'suspiciousCode',
   'typeInvalidation',
-  'undefinedNames',
   'undefinedVars',
   'underscore',
   'unknownDefines',