chore: Remove declareLegacyNamespace() from field_* files #5522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Field angle is now migrated: https://github.com/google/blockly/pull/5521/files Can be addressed in the next PR though. |
alschmiedt
approved these changes
Sep 23, 2021
gonfunko
force-pushed
the
field_namespace
branch
from
da893a1 to
ede7e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm test.The details
Proposed Changes
Removes declareLegacyNamespace() from field_*, other than field_angle.js since it has not yet been goog.module-ified. Also fixed up events_block_change.js to directly require and use BlockBase, since it was causing errors in the node test when declareLegacyNamespace was removed from the field_ files.