fix: Prevent request of (non-existent) closure/goog/deps.js #5499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the only part of the Closure Library we have is base.js, prevent it from trying to load deps.js from the same directory. (We already load our own dependency graph from tests/deps.js.)
alschmiedt
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_modulenpm test.The details
Resolves
Fixes #5103
Proposed Changes
Since the only part of the Closure Library we have is
closure/goog/base.js, set the globalCLOSURE_NO_DEPSflag to prevent it from trying to loaddeps.jsfrom the same directory.Additional Information
We already load our own dependency graph from
tests/deps.js.