Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move Blockly.svgResize to Blockly.common #5485

Merged
merged 3 commits into from
Sep 16, 2021
Merged

refactor: Move Blockly.svgResize to Blockly.common #5485

merged 3 commits into from
Sep 16, 2021

Conversation

maribethb
Copy link
Contributor

The basics

  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide
  • My code is presented in the form suggested in the module
    conversion guide
  • I have run npm test.

The details

Resolves

Part of #5026 and #5208

Proposed Changes

  • Moves Blockly.svgResize to Blockly.common.svgResize
  • Adds an alias for the above
  • Update all internal core usage (not demos)

Additional Information

Does not:

  • Add this to the renaming file
  • Fix this in demos

I will do the above 2 things in a separate PR so that blockly.js can be converted in parallel.

@maribethb maribethb requested a review from a team as a code owner September 16, 2021 22:31
@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Sep 16, 2021
@github-actions github-actions bot added this to the 2021_q3_release milestone Sep 16, 2021
@maribethb maribethb requested a review from gonfunko September 16, 2021 22:31
@maribethb maribethb merged commit 6dbc534 into google:goog_module Sep 16, 2021
@maribethb maribethb mentioned this pull request Sep 21, 2021
Closed
33 tasks
@maribethb maribethb deleted the module_svgresize branch April 1, 2022 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonfunko gonfunko gonfunko approved these changes

@rachel-fenichel rachel-fenichel Awaiting requested review from rachel-fenichel

Assignees

@gonfunko gonfunko

Labels
cla: yes Used by Google's CLA checker. type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
2 participants
@maribethb @gonfunko