Migrate core/utils.js to goog.module syntax #5446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Blockly.utils.svgPaths in core/rendered_connection.js - Blockly.utils.colour in core/toolbox/category.js - Blockly.utils.KeyCodes in core/toolbox/toolbox.js
Note that with core/utils.js in this form test/playground.html will
load and run correctly, but npm run build:compressed fails with many
errors like:
ERROR - [JSC_REFERENCE_TO_MODULE_GLOBAL_NAME] References to the global
name of a module are not allowed. Perhaps you meant exports?
69| const xy = new Blockly.utils.Coordinate(0, 0);
^^^^^
I expect that this will be fixed in the next commit, when named
requires are used instead.
rachel-fenichel
approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm test.The details
Resolves
Part of #5026
Proposed Changes
Converts
core/utils.jstogoog.modulewith ES6const/let.Additional Information
The first commit adds some missing requires (where modules were using
Blockly.utils.<something>after having only importedBlockly.utils).