Migrate core/events/block_events.js to goog.module syntax #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moniika
added
the
breaking change
github-actions
bot
removed
breaking change
|
|
moniika
added
the
breaking change
added 6 commits
August 6, 2021 15:55
moniika
force-pushed
the
convert-block_events
branch
from
29ee359 to
61aca92
Compare
gonfunko
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
goog_modulegoog_moduleconversion guide
npm testlocally already.The details
Resolves
Part of #5026
Proposed Changes
Converts
core/events/block_events.jstogoog.modulesyntax.Removes the following deprecated provides:
Blockly.Events.Change(replaced byBlockly.Events.BlockChange)Blockly.Events.Create(replaced byBlockly.Events.BlockCreate)Blockly.Events.Delete(replaced byBlockly.Events.BlockDelete)Blockly.Events.Move(replaced byBlockly.Events.BlockMove)Updates tests using deprecated provides.
Additional Information
Splits the modules in
core/events/block_events.jswere into the files:core/events/events_block_base.jscore/events/events_block_change.jscore/events/events_block_create.jscore/events/events_block_delete.jscore/events/events_block_move.js