Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate core/utils/style.js to goog.module syntax #5060

Merged
merged 5 commits into from
Jul 19, 2021
Merged

Migrate core/utils/style.js to goog.module syntax #5060

merged 5 commits into from
Jul 19, 2021

Conversation

gonfunko
Copy link
Contributor

The basics

  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide
  • My code is presented in the form suggested in the module
    conversion guide
  • I have run npm test locally already.

The details

Resolves

Part of #5026

@gonfunko gonfunko requested a review from a team as a code owner July 14, 2021 21:13
@gonfunko gonfunko requested a review from rachel-fenichel July 14, 2021 21:13
moniika
moniika approved these changes Jul 15, 2021
View reviewed changes
Copy link
Contributor

@moniika moniika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
We might want to wait on merging until we resolve discussion how we want to handle the @private annotation.

@cpcallen cpcallen added this to the 2021_q3_release milestone Jul 15, 2021
@gonfunko gonfunko merged commit 821cdce into google:goog_module Jul 19, 2021
@gonfunko gonfunko deleted the style branch July 19, 2021 16:45
@cpcallen cpcallen mentioned this pull request Jul 20, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moniika moniika moniika approved these changes

@rachel-fenichel rachel-fenichel Awaiting requested review from rachel-fenichel

Assignees
No one assigned
Labels
type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
3 participants
@gonfunko @moniika @cpcallen