Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate object.js to goog.module syntax #5057

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Migrate object.js to goog.module syntax #5057

merged 4 commits into from
Jul 14, 2021

Conversation

gonfunko
Copy link
Contributor

The basics

  • [ ] I branched from develop
  • [ ] My pull request is against develop
  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide

The details

Resolves

Part of #5026

Proposed Changes

Converts object.js to goog.module syntax.

Test Coverage

Ran npm run start and npm run test

@gonfunko gonfunko requested a review from cpcallen July 14, 2021 18:15
@gonfunko gonfunko requested a review from a team as a code owner July 14, 2021 18:15
@gonfunko gonfunko merged commit bad4b70 into google:goog_module Jul 14, 2021
@gonfunko gonfunko deleted the object branch July 14, 2021 18:19
@cpcallen cpcallen added this to the 2021_q3_release milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moniika moniika moniika approved these changes

@cpcallen cpcallen Awaiting requested review from cpcallen

Assignees
No one assigned
Labels
type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
3 participants
@gonfunko @moniika @cpcallen