-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial commit for appengine deploy action #4998
Initial commit for appengine deploy action #4998
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand we're probably going to test this after it's merged in, so I'm going to approve.
I only have a few straightforward comments on the solely on the comments in the workflow file.
@@ -0,0 +1,54 @@ | |||
# This is a basic workflow to help you get started with Actions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer this description be updated to describe this specific workflow.
Re: the promote flag (pros and cons). Our current system where we don't promote when we deploy is nice in that we can test the deploy works fine before migrating traffic. I like that extra protection, but admit that it is a little inconvenient to need to go to patheon and navigate the site to do the migration. |
Since the migrate can be done with the |
Another option is to have separate workflows for deploying and promoting--that way we run them all from github actions, but we still have time to test in before promoting.
One of the goals is to not need to have gcloud installed locally (and set up, and authed) in order to do this. |
I merged this to develop and tried to test it, but manually running a workflow only works if it's defined in the default branch (master for us) so I'll need to make a PR with these changes against master instead. The new PR is #5005 |
Then my suggestion was terrible and you are right to ignore it! |
The basics
The details
Resolves
#4988
Proposed Changes
Behavior Before Change
Deploying had to be done manually.
Behavior After Change
Deploying will be done by clicking a button in github.
Reason for Changes
Automate tasks
Test Coverage
Not yet tested
Documentation
Internal documentation on how to release will need to be updated.
Additional Information
promote: false
orpromote: true
)../_deploy
. I don't know if that's actually accessible from a workflow