Updating bump logic to support single-direction scrollbars #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moniika
force-pushed
the
bump-with-cleanup
branch
from
46f2bdc to
ea04ab0
Compare
moniika
force-pushed
the
bump-with-cleanup
branch
2 times, most recently
from
644cd11 to
f8a9a47
Compare
moniika
force-pushed
the
bump-with-cleanup
branch
from
f8a9a47 to
5769269
Compare
moniika
commented
Feb 25, 2021
This was referenced Feb 25, 2021
alschmiedt
reviewed
Feb 26, 2021
alschmiedt
approved these changes
Mar 1, 2021
core/inject.js
Outdated
| @@ -387,7 +384,7 @@ Blockly.init_ = function(mainWorkspace) { | |||
| mainWorkspace, true, true, 'blocklyMainWorkspaceScrollbar'); | |||
| mainWorkspace.scrollbar.resize(); | |||
| } else { | |||
| mainWorkspace.setMetrics({x: 0.5, y: 0.5}); | |||
| mainWorkspace.setMetrics({x: 0, y: 0}); | |||
There was a problem hiding this comment.
Just curious, why the change?
There was a problem hiding this comment.
I believe I changed it because it fixed unit tests. However it looks like it doesn't make a difference now, so I'll change it back.
I think it's possible that the scrollbar logic refactor PR may have something to do with it.
added 2 commits
March 1, 2021 12:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Part of #1292
Proposed Changes
getScrollMetricsand adds scroll metrics to the metrics objectBlockly.utils.Metrics)Reason for Changes
Necessary to support single-direction scrollbar
Test Coverage
Extensive manual testing in playground. Mocha tests.
Tested on:
Documentation
Additional Information
Remake of #4618