Remove navigation #4593
Remove navigation #4593
Conversation
core/toolbox/toolbox.js
Outdated
| * @type {function(!Blockly.ShortcutRegistry.KeyboardShortcut):boolean} | ||
| * @public | ||
| */ | ||
| Blockly.Toolbox.prototype.onShortcut; |
There was a problem hiding this comment.
Since onShortcut isn't implemented, doesn't that mean that this class isn't properly implementing the IKeyboardAccessible interface?
There was a problem hiding this comment.
I think you are correct. I added a function that returns false. This mirrors what I do with Blockly.Field.
| @@ -27,7 +25,6 @@ goog.requireType('Blockly.ShortcutRegistry'); | |||
| * A cursor controls how a user navigates the Blockly AST. | |||
| * @constructor | |||
| * @extends {Blockly.Marker} | |||
| * @implements {Blockly.IBlocklyActionable} | |||
There was a problem hiding this comment.
Is it correct that this class isn't going to implement IKeyboardAccessible?
There was a problem hiding this comment.
Yup, the main reason we had onAction on the cursor was so someone could easily add a shortcut. The shortcut registry makes this easy without onAction being necessary.
|
|
||
| /** | ||
| * Handles the given action. | ||
| * @param {!Blockly.ShortcutRegistry.KeyboardShortcut} action The action to be handled. | ||
| * @return {boolean} True if the action has been handled, false otherwise. | ||
| */ | ||
| Blockly.IBlocklyActionable.prototype.onBlocklyAction; | ||
| Blockly.IKeyboardAccessible.prototype.onShortcut; |
There was a problem hiding this comment.
It's not clear to me why this was renamed to onShortcut.
Related, it might help to reword the JSDoc since it's not longer called on action.
There was a problem hiding this comment.
The keyboard shortcut registry replaced the idea of Blockly.Actions, so it makes more sense now to have these handlers be named onShortcut instead of onAction.
Yup, good catch.
alschmiedt
added
the
breaking change
The basics
The details
Resolves
Proposed Changes
Removes keyboard navigation from core.
Reason for Changes
We will be offering keyboard navigation as a plugin.
Test Coverage
Tested on:
Documentation
Additional Information