Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a blocklyCollapsed CSS class to collapsed blocks' root SVG #8264

Closed
BeksOmega opened this issue Jul 9, 2024 · 4 comments
Closed

Add a blocklyCollapsed CSS class to collapsed blocks' root SVG #8264

BeksOmega opened this issue Jul 9, 2024 · 4 comments
Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Milestone
v12

Comments

@BeksOmega
Copy link
Collaborator

To Fix

In the updateCollapsed method call dom.addClass on the this.svgGroup_ to add the blocklyCollapsed class, or dom.removeClass to remove it.

The PR to fix this should be made against the rc/v12.0.0 branch.

To work on this issue, please comment below asking to be assigned.
@BeksOmega BeksOmega added this to the v12 milestone Jul 9, 2024
@BeksOmega BeksOmega added help wanted External contributions actively solicited PR: feature Adds a feature good first issue issue: feature request Describes a new feature and why it should be added and removed PR: feature Adds a feature labels Jul 9, 2024
ga-fleury added a commit to ga-fleury/blockly that referenced this issue Jul 11, 2024
@ga-fleury
feat: Add a blocklyCollapsed CSS class to collapsed blocks' root SVG (g…
116fabf 
…oogle#8264)
@ga-fleury ga-fleury mentioned this issue Jul 11, 2024
Merged
@BeksOmega
Copy link
Collaborator Author

@ga-fleury is working on this

@Apocalypse96
Copy link

@BeksOmega I would love to solve this issue

@sachan13harshit
Copy link

@BeksOmega can you pls assign it to me?

BeksOmega pushed a commit that referenced this issue Jul 22, 2024
@ga-fleury
feat: Add a blocklyCollapsed CSS class to collapsed blocks' root SVG (#…
348313a 
…8264) (#8308)

* feat: Add a blocklyCollapsed CSS class to collapsed blocks' root SVG (#8264)

* format
@BeksOmega
Copy link
Collaborator Author

Closed by #8308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted External contributions actively solicited issue: feature request Describes a new feature and why it should be added
Projects
None yet
Milestone
v12
Development

No branches or pull requests
3 participants
@BeksOmega @sachan13harshit @Apocalypse96