Disabling only one field on a block #4932
Labels
Milestone
Comments
jschanker
added
issue: triage
moniika
added
component: fields
and removed
issue: triage
jschanker
added a commit
to jschanker/blockly
that referenced
this issue
Jun 20, 2021
3 tasks
jschanker
added a commit
to jschanker/blockly
that referenced
this issue
Jun 20, 2021
* Fixed lint error (moved && to end of line and adjusted line breaks accordingly)
|
Stumbled upon duplicate #2763 while looking at the Icebox issues. Close this as duplicate? |
|
I think this one has more detail so I'm going to keep this one and close the other =) Plus this issue is already linked to your PR. I've added the forum link from that issue to this one. Thanks for finding the dupe! |
This was referenced Jul 6, 2021
maribethb
pushed a commit
that referenced
this issue
Jul 20, 2021
* Permit single field disabling (#4932) * Permit single field disabling (#4932) * Fixed lint error (moved && to end of line and adjusted line breaks accordingly) * Added XML Field (De)Serialization * Call parent method in FieldDropdown's fromXml * Added protected helper methods to handle serialization/deserialization of enabled property/attribute of fields * Minor changes to annotations to account for field disabling and 4 spaces per line break per style guide * Revert "Added XML Field (De)Serialization" This reverts commit 1964e86. * Comment style changes * Comment reversions * Indentation fix * Indentation reversion
|
Resolved by #4941. |
moniika
pushed a commit
that referenced
this issue
Jul 20, 2021
* Permit single field disabling (#4932) * Permit single field disabling (#4932) * Fixed lint error (moved && to end of line and adjusted line breaks accordingly) * Added XML Field (De)Serialization * Call parent method in FieldDropdown's fromXml * Added protected helper methods to handle serialization/deserialization of enabled property/attribute of fields * Minor changes to annotations to account for field disabling and 4 spaces per line break per style guide * Revert "Added XML Field (De)Serialization" This reverts commit 1964e86. * Comment style changes * Comment reversions * Indentation fix * Indentation reversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
While you can disable all fields on a block by calling setEditable on it, there doesn't appear to be a method to disable only one of its fields.
Describe the solution you'd like
Introduce a
setEnabledmethod for fields so you can toggle whether the editor will display or not.Describe alternatives you've considered
Additional context
Related to the question in the post on the Blockly forum here: https://groups.google.com/g/blockly/c/tnWc8-WM1lk
[Beka] And this topic as well: https://groups.google.com/d/msg/blockly/OiUL3gzGATQ/WUadyexeBwAJ
The text was updated successfully, but these errors were encountered: