-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed opt_ prefix from optional parameters and gave them default value in plugins #775
Conversation
and gave them default value
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
@rachel-fenichel can you review this? |
I have fixed the typo causing test to fail , can you rerun the tests? |
@alschmiedt is going to take over review today. I had to approve tests for the first run, but now they'll run automatically on push. |
@rachel-fenichel understood |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
A few of the comments have to do with our types which can be a bit tricky so definitely let me know if you have any questions or if there is anything I can clarify!
@alschmiedt thanks for feedback , i will change my code accordingly |
Can someone approve the workflow to run? |
It looks like I was wrong about workflows running automatically--I have to approve it every time on this pull request, but hopefully not on future ones. Thanks for your patience. |
and added undefined as possible type
@alschmiedt i have reverted unnecessary changes and only changed what was needed , can you review it? And also can you approve the workflow to run? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for all your work on this PR!
fixes #667