Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed opt_ prefix from optional parameters and gave them default value in plugins #775

Merged
merged 8 commits into from
Jun 21, 2021

Conversation

lazy-geek
Copy link
Contributor

fixes #667

@google-cla
Copy link

google-cla bot commented Jun 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lazy-geek
Copy link
Contributor Author

@googlebot I signed it!

@lazy-geek
Copy link
Contributor Author

@rachel-fenichel can you review this?

@lazy-geek
Copy link
Contributor Author

I have fixed the typo causing test to fail , can you rerun the tests?

@rachel-fenichel
Copy link
Collaborator

@alschmiedt is going to take over review today. I had to approve tests for the first run, but now they'll run automatically on push.

@lazy-geek
Copy link
Contributor Author

@rachel-fenichel understood

Copy link
Contributor

@alschmiedt alschmiedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

A few of the comments have to do with our types which can be a bit tricky so definitely let me know if you have any questions or if there is anything I can clarify!

plugins/block-plus-minus/src/field_minus.js Outdated Show resolved Hide resolved
plugins/block-plus-minus/src/field_plus.js Outdated Show resolved Hide resolved
plugins/continuous-toolbox/src/ContinuousMetrics.js Outdated Show resolved Hide resolved
plugins/continuous-toolbox/src/ContinuousMetricsFlyout.js Outdated Show resolved Hide resolved
plugins/field-date/src/field_date.js Outdated Show resolved Hide resolved
plugins/field-date/src/field_date.js Outdated Show resolved Hide resolved
plugins/field-slider/src/field_slider.js Outdated Show resolved Hide resolved
plugins/field-slider/src/field_slider.js Outdated Show resolved Hide resolved
plugins/fixed-edges/src/index.js Outdated Show resolved Hide resolved
@lazy-geek
Copy link
Contributor Author

@alschmiedt thanks for feedback , i will change my code accordingly

@lazy-geek lazy-geek requested a review from alschmiedt June 19, 2021 13:01
@lazy-geek
Copy link
Contributor Author

Can someone approve the workflow to run?

@rachel-fenichel
Copy link
Collaborator

It looks like I was wrong about workflows running automatically--I have to approve it every time on this pull request, but hopefully not on future ones. Thanks for your patience.

@lazy-geek
Copy link
Contributor Author

lazy-geek commented Jun 21, 2021

@alschmiedt i have reverted unnecessary changes and only changed what was needed , can you review it? And also can you approve the workflow to run?

Copy link
Contributor

@alschmiedt alschmiedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for all your work on this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename variables that start with opt_
3 participants