-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated CONTRIBUTING.md file to point at dev sites insead of GitHub wiki sites. #722
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
:wave: Welcome! We'd love to accept your patches and contributions to this project. | ||
:wave: Welcome! We'd love to accept your patches and contributions to this project. | ||
|
||
## How can I contribute? | ||
|
||
- [Suggest](https://github.com/google/blockly-samples/issues/new?assignees=&labels=type%3A+feature+request%2C+triage&template=feature_request.md) plugins, examples, or codelabs | ||
- :arrow_right: Start by reading [How To Write A Good Issue](https://github.com/google/blockly-samples/wiki/How-to-Write-a-Good-Issue) | ||
- :arrow_right: Start by reading [How To Write A Good Issue](https://developers.google.com/blockly/guides/modify/contribute/write_a_good_issue) | ||
- Implement plugins, examples, or codelabs | ||
- :arrow_right: Read up on how to [Add a Plugin](https://github.com/google/blockly-samples/wiki/Adding-A-Plugin) or [Write a Codelab](https://github.com/google/blockly-samples/wiki/Writing-a-Codelab) | ||
- [Report bugs](https://github.com/google/blockly-samples/issues/new?assignees=&labels=type%3A+bug%2C+triage&template=bug_report.md) | ||
- :arrow_right: Start by reading [How To Write A Good Issue](https://github.com/google/blockly-samples/wiki/How-to-Write-a-Good-Issue) | ||
- Fix bugs | ||
- :arrow_right: Read up on how to [Add a Plugin](https://developers.google.com/blockly/guides/modify/contribute/add_a_plugin) or [Write a Codelab](https://developers.google.com/blockly/guides/modify/contribute/write_a_codelab) | ||
- [Report bugs](https://github.com/google/blockly-samples/issues/new?assignees=&labels=type%3A+bug%2C+triage&template=bug_report.md) | ||
- :arrow_right: Start by reading [How To Write A Good Issue](https://developers.google.com/blockly/guides/modify/contribute/write_a_good_issue) | ||
- [Fix bugs](https://developers.google.com/blockly/guides/modify/contribute/issue_labels) | ||
- :arrow_right: Start by reading [Finding a Good Issue](https://github.com/google/blockly-samples/wiki/Finding-a-Good-Issue:-Labels) | ||
|
||
## Contributor License Agreement | ||
|
@@ -26,14 +26,15 @@ again. | |
## Code reviews | ||
|
||
All submissions, including submissions by project members, require review. We | ||
use GitHub pull requests for this purpose. | ||
use GitHub pull requests for this purpose. | ||
|
||
:arrow_right: Read more about our [PR review process](https://github.com/google/blockly-samples/wiki/The-Pull-Request-Review-Process) in the wiki. | ||
:arrow_right: Read more about our [PR review process](https://developers.google.com/blockly/guides/modify/contribute/pr_review_process) in the wiki. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove the text "in the wiki" |
||
|
||
## Community guidelines | ||
|
||
This project follows | ||
[Google's Open Source Community Guidelines](https://opensource.google.com/conduct/). | ||
|
||
## More information | ||
Head over to the [wiki](https://github.com/google/blockly-samples/wiki) for more information, including an [overview of the repository structure](https://github.com/google/blockly-samples/wiki/Repository-Structure) and details of our [publishing process](https://github.com/google/blockly-samples/wiki/Plugin-Publishing). | ||
|
||
Head over to the [wiki](https://developers.google.com/blockly/guides/modify/contributing) for more information, including an [overview of the repository structure](https://developers.google.com/blockly/guides/modify/contribute/samples_repository_structure) and details of our [publishing process](https://developers.google.com/blockly/guides/modify/contribute/add_a_plugin#publishing). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change "wiki" to "Developer Site" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link should be on
Finding a Good Issue
below instead. Currently that one still links to the wiki. It should link to dev site instead andFix bugs
shouldn't have a link.