Bundling Blockly with Parcel #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alschmiedt
reviewed
May 6, 2021
| import 'blockly/python'; | ||
|
|
||
| import * as En from 'blockly/msg/en'; | ||
| Blockly.setLocale(En); |
There was a problem hiding this comment.
nit: Add a line between imports and the first line of code.
examples/blockly-parcel/src/index.js
Outdated
| alert("Check the console for the generated output."); | ||
| const code = Blockly[lang].workspaceToCode(workspace); | ||
| console.log(code); | ||
| }) |
| alert("Check the console for the generated output."); | ||
| const code = Blockly[lang].workspaceToCode(workspace); | ||
| console.log(code); | ||
| }) |
|
|
||
|
|
||
| document.addEventListener("DOMContentLoaded", function () { | ||
| const workspace = Blockly.inject('blocklyDiv', |
There was a problem hiding this comment.
Should be an indent of 2 instead of 4.
examples/blockly-parcel/src/index.js
Outdated
Comment on lines
1
to
16
| /** | ||
| * @license | ||
| * | ||
| * Copyright 2021 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. |
There was a problem hiding this comment.
This can now be replaced with:
/**
* @license
* Copyright 2021 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
|
@alschmiedt Thank you for reviewing. I applied your remarks to all the sources. |
|
😱 @alschmiedt I think I replaced spaces with tabs and now github renders it with 8 spaces instead of the original 4 while my vim renders it with 2. Let me try to fix that. Sorry about that. |
moniika
approved these changes
May 7, 2021
This was referenced Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #681
Bundle Blockly in a Parcel project. Modeled on a similar example of bundling blockly with Webpack project.