Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Migrating every theme to TypeScript. #2474

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

tgbhy
Copy link

@tgbhy tgbhy commented Dec 30, 2024

The basics

The details

Resolves

Fixes #2158

Proposed Changes

Migrate every theme sample to TypeScript.

Reason for Changes

It would be usable in TypeScript like explained in the fixed issue.

Test Coverage

Manually tested with a Windows 10 PC and Brave Browser.
I tested on using a default installation of Blockly and recreating the schema of each readme-media/Theme.png

@tgbhy tgbhy requested a review from a team as a code owner December 30, 2024 22:36
@tgbhy tgbhy requested review from cpcallen and removed request for a team December 30, 2024 22:36
Copy link

google-cla bot commented Dec 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cpcallen cpcallen added the category: plugin Anything in the plugins folder label Jan 9, 2025
@cpcallen
Copy link
Contributor

cpcallen commented Jan 9, 2025

Hi @tgbhy. Thanks for this useful PR! The changes look good but there are some additional steps needed before we can accept the PR:

  • You'll need to agree to the CLA.
  • eslint is unhappy about all the properties with underscores in their name. You'll need to disable this rule for these declarations.
  • You'll also need to run npm run format to run Prettier and thereby fix the formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: plugin Anything in the plugins folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert theme plugins to ts
2 participants