fix(developer-tools): Copy buttons not working in Blockly Developer Tools #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
… tools The copy buttons for generated code blocks in Blockly Developer Tools were not functioning correctly in the latest versions of Firefox and Chrome. This fix ensures that the copy buttons work as expected and improves user experience. Related issue: google#2433
jenish-thapa
force-pushed
the
fixes/copy-buttons
branch
from
73bc83e to
f30cd83
Compare
cpcallen
changed the title
cpcallen
changed the title
cpcallen
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2433
Proposed Changes
This pull request addresses the issue where clicking on the copy buttons for generated code blocks in Blockly Developer Tools does not work. The problem occurs on both the latest versions of Firefox and Chrome. The changes include updates to class names of the copy buttons and fixes clipboard interactions.
Reason for Changes
The copy buttons were not functioning correctly, which hindered users from copying generated code blocks. The changes ensure that the copy functionality works as expected, improving the user experience in Blockly Developer Tools.
Test Coverage
NA
Documentation
NA
Additional Information
NA