fix: updated onDragEnter for backpack plugin to check for backpackabl… #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e instead of block
changminbark
requested review from
rachel-fenichel
and removed request for
a team
rachel-fenichel
approved these changes
Jul 23, 2024
|
Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2420
Proposed Changes
Changes the onDragEnter (hovering over backpack icon) to check for a backpackable object instead of a BlockSvg.
Reason for Changes
This makes it cover more use-cases for the backpack plugin as well as make it possible for the multiselection in the multiselect plugin to also cause the hover UI change for the backpack.
Test Coverage
Documentation
Additional Information