chore: Clean up and convert field-bitmap to Typescript #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Feb 29, 2024
|
|
||
| import Blockly from 'blockly/core'; | ||
|
|
||
| export const DEFAULT_HEIGHT = 5; |
There was a problem hiding this comment.
note on the lint errors: rachel has an update to the eslint config that allows constant case. it's bundled in another pr. I will poke her about submitting that when she is feeling better
There was a problem hiding this comment.
Ah nice, and sounds good!
gonfunko
force-pushed
the
bitmap-nonsquare
branch
from
1318bf0 to
21ee8d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Part of #1647
Proposed Changes
This PR converts field-bitmap to Typescript. It also includes some light refactoring and cleanup of the code.