fix: text join block warning when using block-plus-minus plugin #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1 task
|
The test failure was expected! Just wanted to make sure it actually failed. |
|
Hello! This looks great @HadyBazzi =) Thank you for the work on it! I just need a few more things before I can get this merged:
|
Fixes #1877. Don't advertise module entrypoints on packages that are implemented in TypeScript as at the moment our webpack configuration does not generate any file called src/index.js.
|
Hello, |
|
Oops, I missed that. Thank you for fixing it! |
Haha 100% all good! Didn't want to bug you with such a minor thing :P Thank you for your work on this! LGTM =) |
BeksOmega
approved these changes
Oct 20, 2023
HadyBazzi
deleted the
fix/text-join-block-warning-when-using-block-plus-minus-plugin
branch
BeksOmega
added a commit
that referenced
this pull request
Dec 7, 2023
* fix: text join block warning when using block-plus-minus plugin * Update package.json * fix(packaging): Don't advertise non-existent ESM entrypoints (#2022) Fixes #1877. Don't advertise module entrypoints on packages that are implemented in TypeScript as at the moment our webpack configuration does not generate any file called src/index.js. * Revert "fix(packaging): Don't advertise non-existent ESM entrypoints (#2022)" This reverts commit 3382ac7. * update package-lock --------- Co-authored-by: Christopher Allen <cpcallen+git@google.com> Co-authored-by: Beka Westberg <bwestberg@google.com>
BeksOmega
added a commit
that referenced
this pull request
Dec 7, 2023
* fix: text join block warning when using block-plus-minus plugin * Update package.json * fix(packaging): Don't advertise non-existent ESM entrypoints (#2022) Fixes #1877. Don't advertise module entrypoints on packages that are implemented in TypeScript as at the moment our webpack configuration does not generate any file called src/index.js. * Revert "fix(packaging): Don't advertise non-existent ESM entrypoints (#2022)" This reverts commit 3382ac7. * update package-lock --------- Co-authored-by: Christopher Allen <cpcallen+git@google.com> Co-authored-by: Beka Westberg <bwestberg@google.com>
BeksOmega
added a commit
that referenced
this pull request
Dec 7, 2023
* fix: text join block warning when using block-plus-minus plugin * Update package.json * fix(packaging): Don't advertise non-existent ESM entrypoints (#2022) Fixes #1877. Don't advertise module entrypoints on packages that are implemented in TypeScript as at the moment our webpack configuration does not generate any file called src/index.js. * Revert "fix(packaging): Don't advertise non-existent ESM entrypoints (#2022)" This reverts commit 3382ac7. * update package-lock --------- Co-authored-by: Christopher Allen <cpcallen+git@google.com> Co-authored-by: Beka Westberg <bwestberg@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
When combined with google/blockly#7598 this resolves #1134.
Proposed Changes
Use the quote_image_mixin extension instead of the text_quotes extension.
Reason for Changes
Using the quote_image_mixin stops the following warning from appearing when using the text_join block with the block-plus-minus plugin due to the text_quotes extension calling
this.quoteField_('TEXT');:field named "TEXT" not found in "text_join" blockAdditional Information
google/blockly#7598 should be passed before this to avoid errors due to the quote_image_mixin not currently existing.