-
Notifications
You must be signed in to change notification settings - Fork 630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bump the blockly peer dependency in dev-tools and remove version probing #1183
Conversation
If this requires us to update the dev-tools dependency then do that in this PR and mark this as a breaking change, then lgtm |
The id generator fix was already reviewed by Aaron in #1184 No need to re-review. Just moving everything into one PR. |
This should be a breaking change. If someone is using blockly v7 then we would not want npm to automatically update them to this version of the plugin since it is no longer compatible. It has to be a major update so that they manually update when needed. You can probably still update the title of this PR to affect lerna's reading of the commit, but I'm not sure. And since this would be a major version update of dev-tools I think that means we need to manually update all of the other plugins to depend on the new version because lerna won't keep them up to date after a major change is what we learned last time. So we should take extra care after the next samples release (which I won't be here next week) |
Yeah :/ whoops.
Pretty sure it won't, because lerna will just be looking at the git history :/ Will revert and reapply with the correct conventional commits.
Sounds good, made a note to myself. |
Description
Work on #882 Also fix google/blockly#6204
Requires us to bump devtools to only work with v8+.