Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Bazel version #189

Open
cpovirk opened this issue Aug 13, 2024 · 1 comment · May be fixed by #195 or #196
Open

Bump Bazel version #189

cpovirk opened this issue Aug 13, 2024 · 1 comment · May be fixed by #195 or #196
Assignees
Labels

Comments

@cpovirk
Copy link
Member

cpovirk commented Aug 13, 2024

We're currently on 5.4.1:

A naive attempt to bump to 7.2.1 leads to errors:

$ ./run_tests.sh # hacked up to run `bazelisk` instead of `bazel`
2024/08/13 13:19:21 Downloading https://releases.bazel.build/7.2.1/release/bazel-7.2.1-linux-x86_64...
Starting local Bazel server and connecting to it...
WARNING: --enable_bzlmod is set, but no MODULE.bazel file was found at the workspace root. Bazel will create an empty MODULE.bazel file. Please consider migrating your external dependencies from WORKSPACE to MODULE.bazel. For more details, please refer to https://github.com/bazelbuild/bazel/issues/18958.
ERROR: no such package '@@bazel_tools//platforms': BUILD file not found in directory 'platforms' of external repository @@bazel_tools. Add a BUILD file to a directory to mark it as a package.
ERROR: /usr/local/google/home/cpovirk/.cache/bazel/_bazel_cpovirk/8e2f63206b10e96a1bf6067cd12cdf5c/external/bazel_skylib/toolchains/unittest/BUILD:22:10: no such package '@@bazel_tools//platforms': BUILD file not found in directory 'platforms' of external repository @@bazel_tools. Add a BUILD file to a directory to mark it as a package. and referenced by '@@bazel_skylib//toolchains/unittest:cmd_toolchain'
ERROR: /usr/local/google/home/cpovirk/clients/bazel-common-gray/bazel-common/build_test/BUILD:1:13: Analysis failed
ERROR: Analysis of target '//build_test:build_test' failed; build aborted
INFO: Elapsed time: 6.584s, Critical Path: 0.03s
INFO: 1 process: 1 internal.
ERROR: Build did NOT complete successfully
ERROR: no such package '@@bazel_tools//platforms': BUILD file not found in directory 'platforms' of external repository @@bazel_tools. Add a BUILD file to a directory to mark it as a package.
ERROR: /usr/local/google/home/cpovirk/.cache/bazel/_bazel_cpovirk/8e2f63206b10e96a1bf6067cd12cdf5c/external/bazel_skylib/toolchains/unittest/BUILD:22:10: no such package '@@bazel_tools//platforms': BUILD file not found in directory 'platforms' of external repository @@bazel_tools. Add a BUILD file to a directory to mark it as a package. and referenced by '@@bazel_skylib//toolchains/unittest:cmd_toolchain'
ERROR: /usr/local/google/home/cpovirk/clients/bazel-common-gray/bazel-common/tools/maven/BUILD:20:15: Analysis failed
Use --verbose_failures to see the command lines of failed build steps.
ERROR: Analysis of target '//tools/maven:TransitiveExports' failed; build aborted
INFO: Elapsed time: 0.604s, Critical Path: 0.01s
INFO: 1 process: 1 internal.
ERROR: Build did NOT complete successfully
ERROR: No test targets were found, yet testing was requested
@cpovirk cpovirk added the P3 label Aug 13, 2024
copybara-service bot pushed a commit that referenced this issue Aug 13, 2024
- The "build_test" started failing to test anything a while back. For now, I've just modified our test process to build everything under //third_party directly.
- Update the sha256 value for protobuf-java. The current value dates from verion 3.7.0 in cl/240867170 because we missed updating it in cl/572680710.
- Make the test script use Bazelisk instead of trying to pick up Bazel from the user's environment (since users probably don't have the ["right"](#189) version installed).

RELNOTES=n/a
PiperOrigin-RevId: 662574179
copybara-service bot pushed a commit that referenced this issue Aug 13, 2024
- The "build_test" started failing to test anything a while back. For now, I've just modified our test process to build everything under //third_party directly.
- Update the sha256 value for protobuf-java. The current value dates from verion 3.7.0 in cl/240867170 because we missed updating it in cl/572680710.
- Make the test script use Bazelisk instead of trying to pick up Bazel from the user's environment (since users probably don't have the ["right"](#189) version installed).

RELNOTES=n/a
PiperOrigin-RevId: 662592617
@cpovirk
Copy link
Member Author

cpovirk commented Sep 25, 2024

More trouble with newer versions documented in google/flogger#387

@chaoren chaoren self-assigned this Sep 25, 2024
copybara-service bot pushed a commit that referenced this issue Oct 2, 2024
copybara-service bot pushed a commit that referenced this issue Oct 2, 2024
PiperOrigin-RevId: 681585285
@copybara-service copybara-service bot linked a pull request Oct 2, 2024 that will close this issue
copybara-service bot pushed a commit that referenced this issue Oct 2, 2024
PiperOrigin-RevId: 681588814
@copybara-service copybara-service bot linked a pull request Oct 2, 2024 that will close this issue
copybara-service bot pushed a commit that referenced this issue Oct 3, 2024
copybara-service bot pushed a commit that referenced this issue Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants