Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates encoding.py to not to set/reset global logger. #142

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Updates encoding.py to not to set/reset global logger. #142

merged 1 commit into from
Jan 30, 2017

Conversation

chamikaramj
Copy link
Contributor

Updates encoding.py to not to set/reset global logger.

Removes a warning log entry that caused above to be added.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 87.492% when pulling 0104dba on chamikaramj:remove_global_error_log_level into a8536ee on google:master.

@chamikaramj
Updates encoding.py to not to set/reset global logger.
5cf5daa 
Removes a warning log entry that caused above to be added.
@chamikaramj chamikaramj force-pushed the remove_global_error_log_level branch from 0104dba to 5cf5daa Compare January 29, 2017 23:05
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 87.491% when pulling 5cf5daa on chamikaramj:remove_global_error_log_level into a8536ee on google:master.

@chamikaramj
Copy link
Contributor Author

This fixes #141

@cherba please let me know how to proceed here.

@cherba cherba merged commit 3334d39 into google:master Jan 30, 2017
@chamikaramj
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chamikaramj @coveralls @googlebot @cherba