-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clang driver: enable fast unaligned access for android #111
Comments
aosp testing in progress: https://android-review.googlesource.com/c/platform/build/soong/+/2734373 |
oh, definitely --- any time we land something in AOSP (and we feel like it's really landed and isn't going to get reverted), we should start moving it upstream. any time i don't suggest that to you is a bug on my part :-) (the alternative is that every single build system has to add these flags, which obviously doesn't scale.) |
merged. |
i think it is okay to keep it open as the currently used (backend) flags will be updated (to -munaligned-access) with the new toolchain. |
Any reason not to use |
Bumping this thread because the last comment mentions we'll have 'unaligned-access' in the new toolchain, and I believe we've completed a round of updates since Oct. @appujee - should we be switching our flags to "-munaligned-access" now? WDYT about @SiFiveHolland 's comments on 'no-strict-align'? |
yes, |
I'll replace the previous workaround with -munaligned-access |
is there a reason we haven't moved this into the driver yet? this flag has been in AOSP for a long time now with no problems... |
The change landed few weeks back, https://android-review.googlesource.com/c/platform/build/soong/+/2977952 I forgot to close this bug. |
Interestingly |
I'll enable the flag by default for Android. llvm/llvm-project#85704 WIP. |
the llvm change was merged ... is that cherrypicked for our llvm? (and is that cherrypick in the toolchain that we're working on currently for the forthcoming ndk release, or is it for the next one?) |
it was cherry-picked to our llvm in https://android-review.googlesource.com/c/toolchain/llvm_android/+/3009313 it is not in the toolchain (clang-r522817) we are working on. |
Cherry-picked in aosp/3009313 Related: google/android-riscv64#111 Bug: 327307773 Change-Id: I996378fad09ce50fb432e1b4506ed273e3ec7019
Maybe we can add this to clang driver once we have tested it?
The text was updated successfully, but these errors were encountered: