Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run instrumentation tests on API 30 instead of 29 #1130

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Feb 8, 2022

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Clear and concise code change description.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct
  • I have read the Contributing page
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally
  • I have built and run the reference app(s) to verify my change fixes the issue and/or does not break the reference app(s)

@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #1130 (37281e5) into master (c06c2a3) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1130      +/-   ##
============================================
- Coverage     84.53%   84.52%   -0.01%     
  Complexity      608      608              
============================================
  Files           134      134              
  Lines         10279    10279              
  Branches        756      756              
============================================
- Hits           8689     8688       -1     
- Misses         1214     1215       +1     
  Partials        376      376              
Impacted Files Coverage Δ
...va/com/google/android/fhir/db/impl/DatabaseImpl.kt 88.88% <0.00%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ff505e...37281e5. Read the comment docs.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@jingtang10 jingtang10 enabled auto-merge (squash) February 8, 2022 11:37
@jingtang10 jingtang10 merged commit a557079 into master Feb 8, 2022
@jingtang10 jingtang10 deleted the jt/api30 branch February 8, 2022 13:26
@jingtang10 jingtang10 linked an issue Feb 8, 2022 that may be closed by this pull request
ktarasenko pushed a commit that referenced this pull request Feb 16, 2022
* Run instrumentation tests on API 30 instead of 29

* Update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

EncryptedDatabaseErrorTest Failing
2 participants