IMA post roll is not playing well #7518

hyl0376 · 2020-06-18T03:29:56Z

[REQUIRED] Issue description

In a demo app, playing post roll after the video ends looks abnormal.

[REQUIRED] Reproduction steps

When video ends with no seeking action, post roll ad layer is not exposed. And then, set app to background (like press home button) and back to foreground, post roll is start at first position not the paused position.
When video ends with seeking action (seek to the end of the video), post roll ad layer is well exposed and played. But set app to background (like press home button) and back to foreground, post roll is stopped.

Tested with ExoPlayer demo app, 'IMA sample ad tags' - VMAP post-roll, VMAP post-roll + bumper.

[REQUIRED] A full bug report captured from the device

[REQUIRED] Version of ExoPlayer being used

2.11.5

[REQUIRED] Device(s) and version(s) of Android being used

Galaxy note8 API 26, Android Emulators API 29

andrewlewis · 2020-06-19T16:19:20Z

Thanks for reporting this. There are two bugs here:

Postrolls now preload (since the recent API changes), but that means we need to trigger content complete when transitioning to the preloaded postroll.
On resuming from background during a postroll, the period duration is unset briefly (I think we no longer use the content duration from the ad playback state) so we think the ad has ended and tell the IMA SDK that, which causes a stopAd call.

We should have a fix for these soon.

The IMA SDK now preloads postrolls which is great as we no longer need to rely on detecting buffering at the end of the stream to trigger playing postrolls. Add in the required logic to detect the period transition to playing the postroll. Issue: #7518 PiperOrigin-RevId: 317610682

Postrolls would be skipped because the period duration wasn't know at the moment of resuming playback after backgrounding, so the position wouldn't be resolved to resume the postroll ad. We have the period duration stored in the AdPlaybackState, so we can use that directly. Issue: #7518 PiperOrigin-RevId: 317830418

The IMA SDK now preloads postrolls which is great as we no longer need to rely on detecting buffering at the end of the stream to trigger playing postrolls. Add in the required logic to detect the period transition to playing the postroll. Issue: #7518 PiperOrigin-RevId: 317610682

Postrolls would be skipped because the period duration wasn't know at the moment of resuming playback after backgrounding, so the position wouldn't be resolved to resume the postroll ad. We have the period duration stored in the AdPlaybackState, so we can use that directly. Issue: #7518 PiperOrigin-RevId: 317830418

ojw28 · 2020-06-23T15:47:29Z

Fixed in the commits referenced above. This will be part of 2.11.6, which should be released today or tomorrow.

hyl0376 added bug needs triage labels Jun 18, 2020

andrewlewis self-assigned this Jun 18, 2020

andrewlewis removed the needs triage label Jun 19, 2020

ojw28 closed this as completed Jun 23, 2020

google locked and limited conversation to collaborators Aug 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IMA post roll is not playing well #7518

IMA post roll is not playing well #7518

hyl0376 commented Jun 18, 2020

andrewlewis commented Jun 19, 2020

ojw28 commented Jun 23, 2020 •

edited

Loading

IMA post roll is not playing well #7518

IMA post roll is not playing well #7518

Comments

hyl0376 commented Jun 18, 2020

[REQUIRED] Issue description

[REQUIRED] Reproduction steps

[REQUIRED] A full bug report captured from the device

[REQUIRED] Version of ExoPlayer being used

[REQUIRED] Device(s) and version(s) of Android being used

andrewlewis commented Jun 19, 2020

ojw28 commented Jun 23, 2020 • edited Loading

ojw28 commented Jun 23, 2020 •

edited

Loading