Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Signed Demo APK Fails #4997

Closed
giladna opened this issue Oct 23, 2018 · 8 comments
Closed

Generate Signed Demo APK Fails #4997

giladna opened this issue Oct 23, 2018 · 8 comments
Assignees

Comments

@giladna
Copy link

giladna commented Oct 23, 2018

Hi,

in order to avoid errors thrown during Signing APK process
"Failed to resolve: play-services-basement"

in this build.gradle file
https://github.com/google/ExoPlayer/blob/r2.9.0/build.gradle

It is required to switch the order or the repositories in the buildscript and in the allprojects keys:

Working for me:

repositories {
google()
jcenter()
}

BR
Gilad

@GonziMalaga
Copy link

I have the same problem, but is not only when signing, is with building the APK.

I've openend another issue because I didn't see yours since I entered github one hour ago and didn't refresh it before creating the new issue.

@tonihei
Copy link
Collaborator

tonihei commented Oct 23, 2018

We had the same problem in the past when it solved itself after a while, see #4353. Worth checking again tomorrow to see if it's only temporary.

@tonihei tonihei self-assigned this Oct 23, 2018
@GonziMalaga
Copy link

Okk for me it works changing the order...

    repositories {
        jcenter()
        google()
    }

to this

    repositories {
        google()
        jcenter()
    }

@ojw28
Copy link
Contributor

ojw28 commented Oct 23, 2018

We should probably do that in the pieces of documentation we have + our own gradle files, given this has happened again?

ojw28 pushed a commit that referenced this issue Oct 24, 2018
This seems to be more stable in case Bintray has issues updating the ExoPlayer
sources.

Issue:#4997

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=218327350
@ojw28 ojw28 closed this as completed Oct 24, 2018
ojw28 pushed a commit that referenced this issue Oct 24, 2018
This seems to be more stable in case Bintray has issues updating the ExoPlayer
sources.

Issue:#4997

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=218327350
@jerrychong25
Copy link

Thanks @GonziMalaga, your solution works!

@YunanChen
Copy link

Thanks very much @GonziMalaga

@Mastrom10
Copy link

Worked for me!!!

@clickboxmobile
Copy link

For me worked like this

buildscript {
    repositories {
        maven {
            url "https://maven.google.com"
        }
        jcenter()
    }

    // Switch the Android Gradle plugin version requirement depending on the
    // installed version of Gradle. This dependency is documented at
    // http://tools.android.com/tech-docs/new-build-system/version-compatibility
    // and https://issues.apache.org/jira/browse/CB-8143
    dependencies {
        classpath 'com.android.tools.build:gradle:2.2.3'
    }
}

// Allow plugins to declare Maven dependencies via build-extras.gradle.
allprojects {
    repositories {
        maven {
            url "https://maven.google.com"
        }
        jcenter()
    }
}

@google google locked and limited conversation to collaborators May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants