Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCTE-35 metadata has incorrect timestamps #4573

Closed
ojw28 opened this issue Jul 25, 2018 · 1 comment
Closed

SCTE-35 metadata has incorrect timestamps #4573

ojw28 opened this issue Jul 25, 2018 · 1 comment
Assignees
@AquilesCanta
Labels
bug

Comments

@ojw28
Copy link
Contributor

ojw28 commented Jul 25, 2018

This is reproducible using the sample provided here.

From an initial look, it appears the samples are queued with incorrect timestamps in SpliceInfoSectionReader.consume. In particular because getLastAdjustedTimestampUs appears to return an unadjusted timestamp, rather than an adjusted one? It could be that simply fixing this is the right thing to do, but it's a bit unclear to me exactly how the subsample offset and its use in SpliceInfoDecoder works, so it's possible I've misunderstood.
@ojw28 ojw28 added the bug label Jul 25, 2018
@ojw28 ojw28 mentioned this issue Jul 25, 2018
Closed
ojw28 pushed a commit that referenced this issue Aug 1, 2018
@AquilesCanta @ojw28
Fix SCTE-35 timestamp adjustment
9ec14d1 
Issue:#4573

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=206737252
ojw28 pushed a commit that referenced this issue Aug 1, 2018
@AquilesCanta @ojw28
Fix SCTE-35 timestamp adjustment
fa1049e 
Issue:#4573

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=206737252
@ojw28
Copy link
Contributor Author

ojw28 commented Aug 1, 2018

This is fixed in dev-v2, and the fix will be included in 2.8.3.

@ojw28 ojw28 closed this as completed Aug 1, 2018
@google google locked and limited conversation to collaborators Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AquilesCanta AquilesCanta

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ojw28 @AquilesCanta