Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMA Ads: listen to events #3322

Closed
rubenweerts opened this issue Oct 4, 2017 · 4 comments
Closed

IMA Ads: listen to events #3322

rubenweerts opened this issue Oct 4, 2017 · 4 comments
Assignees

Comments

@rubenweerts
Copy link

rubenweerts commented Oct 4, 2017

Issue description

As a developer I want to be able to respond to certain events. The events of these interfaces are hidden when using the Ima-extension: AdErrorListener, AdsLoadedListener, AdEventListener
I'm currently unable to respond to these events:

ALL_ADS_COMPLETED,
FIRST_QUARTILE,
MIDPOINT,
SKIPPED,
TAPPED,
ICON_TAPPED,
THIRD_QUARTILE,
LOADED,
AD_PROGRESS

A solution would be to allow an external listener to receive these events aswel. i.e. ImaAdsLoader.addAdEventListener() and ImaAdsLoader.addAdErrorListener(), ect.
Or make an encapsulating listener that transfers all 3 listeners to external code.

Another quicker solution could be to not make the class final so I can add the functionality myself.

Reproduction steps

None, this is a feature request to open up the SDK

Link to test content

None needed

Version of ExoPlayer being used

r2.5.3

Device(s) and version(s) of Android being used

Any device, but for the sake to name one I'm using the Nexus 6p.

A full bug report captured from the device

See description

@andrewlewis andrewlewis self-assigned this Oct 4, 2017
@andrewlewis
Copy link
Collaborator

I wonder if we should just provide a getter for the com.google.ads.interactivemedia.v3.api.AdsLoader field. Then you could add an additional AdErrorListener and AdsLoadedListener in your app, and in the AdsLoadedListener you could get the AdsManager and attach another AdEventListener. Does that sound like it would meet your requirements?

@rubenweerts
Copy link
Author

rubenweerts commented Oct 9, 2017

Yes, that sounds good. Any solution that allows me to receive the original IMA SKD's events is fine 👍

ojw28 pushed a commit that referenced this issue Oct 11, 2017
Issue: #3322

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=171508635
@mitchellwit
Copy link

When can we expect this to be in release?

@ojw28
Copy link
Contributor

ojw28 commented Nov 8, 2017

It's in 2.6.0, for which there's current a dev branch. We're still finishing off a few bits and pieces to cherry-pick into it, and expect it to be pushed sometime next week (no promises though).

@google google locked and limited conversation to collaborators Feb 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants