-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support PGS and VOBSUB subtitles #3008
Comments
I don't think we support either at the moment. Marking as an enhancement. We're unlikely to prioritize this, however, so the most likely path to this being supported would be an external contribution. |
I had submitted code awhile back for PGS that was rejected because I translated the ffmpeg implementation into java. Afterwards I started an implementation from scratch using other sources as documentation. I implemented it in my video app which can be viewed here: Anyone who wants to take what I did and integrate it into ExoPlayer is welcome to. |
@drhill - If it's just that package (i.e. the three files), and if you could provide a few pieces of test content, then that looks like something we could get merged relatively easily. We'd really need the files sent as a proper pull request from yourself though; it's important that we have a proper attribution trail for all changes we accept. Thanks! |
PR: #3673 |
Issue: #3008 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=181455340
PGS is now supported (thanks @drhill!). Assuming VOBSUB is different, I think we'd add support if and only if someone provides a contribution. |
Hello,
Issue description
From the documentation and the conversations here I expected PGS and VOBSUB subtitles to work in ExoPlayer, but it seems they are not rendered.
Reproduction steps
Use the ExoPlayer demo app with this sample content from the Kodi repository of samples:
https://drive.google.com/file/d/0BwxFVkl63-lEVEluSFZ4NlhpLUk/view
Link to test content
See above, which is a MKV with PGS.
Unfortunately I don't have a sample with a VOBSUB track that I can share, but those tracks aren't rendered either.
Version of ExoPlayer being used
ExoPlayer version 2.4.2, used via gradle.
Device(s) and version(s) of Android being used
Nexus Player with Android 7.1.2
The text was updated successfully, but these errors were encountered: