-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support AVI #2092
Comments
No, this is not supported in V2. Someone would have to implement an ExoPlayer AVI extractor. It's unclear there's really any significant demand for it, however. |
I would also like to see an ExoPlayer avi extractor implemented. |
Same here, i would love to see .avi extractor, nothing out there ? |
I would be happy to see .avi extractor |
Any updates on this? This should be bumped up. The fact that AVI format is horribly outdated and nobody should use it is not going to deter our simple minded users! ~7% of the files that my users try to play every day are AVI. With 20k DAU, this is insane. I get at least one 1-star review everyday specifically about this. |
I would also like to see an ExoPlayer avi extractor implemented. |
Yes , please add support for this kind of format :-) |
i believe there is in fact significant demand for this
|
Please add support for .avi extractor. We would love to see that. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Still neither avi nor wmv support is added. |
Also waiting for avi support |
if they didn't care to add it in the last 4 years, and even marked it as "low priority" (2 years ago) there is ZERO chances they will implement an avi extractor. I say this as I know how google works 🙃 . |
Although it is not commonly used for streaming, it is still very common in trail cams, lower end dash cams and drones. I don't know how many people I've told to install VLC over the years. |
We still need .avi support why is this being ignored |
Because they think no one needs it even though we all keep saying we do |
To clarify, we do understand there's some demand and value to implementing this. As is the case with most widely used open source projects, we receive far more requests than we're able to handle, and we need to prioritize what we work on fairly ruthlessly. This feature is not important enough for us to work on at this point in time. We accept open source contributions, and would accept a high quality pull request that adds an AVI extractor. ExoPlayer is also extensible enough such that you could implement an AVI extractor and inject it into the player from your own codebase. In other words, the direct development team are not the only group of people who could add support for this. |
I'll have some time this summer to work on it. I have a lot of experience
with different containers and I've read the AVI and OpenDML spec. Based on
my personal library, it looks like the primary codecs are MJPEG/PCM and
H263 (xvid) and AC3. Both combos have challenges with ExoPlayer/stock
Android. There are also a ton of trail cams out there that still use AVI.
I'm not sure what they are using. My neighbor has one, I'll get some
samples...
…On Thu, Oct 29, 2020 at 10:16 AM Oliver Woodman ***@***.***> wrote:
To clarify, we do understand there's some demand and value to implementing
this. As is the case with most widely used open source projects, we receive
far more requests than we're able to handle, and we need to prioritize what
we work on fairly ruthlessly. This feature is not important enough for us
to work on at this point in time.
We accept open source contributions, and would accept a high quality pull
request that adds an AVI extractor. ExoPlayer is also extensible enough
such that you could implement an AVI extractor and inject it into the
player from your own codebase. In other words, the direct development team
are not the *only* group of people who could add support for this.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2092 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABM2VUIHMTLL5TVH7V2L4F3SNGIOJANCNFSM4CXGQFCA>
.
|
.avi has been largely replaced by .mp4, webm, and even more-so mkv so it makes sense that the devs don't really care about that container anymore. It's up to the community to submit a PR and it has to happen sooner than later because the more time passes, the less people are interested in working on it. |
@dburckh , how is it going? |
I am still waiting avi extractor. |
Please add AVI support |
Regarding: "AVI will go away and be replaced by MP4": the MP4 container is from the MPEG consortium and only supports MPEG streams. This means that you cannot get other streams in it without conversion. E.g. H.263 video + PCM audio does not work. But that's what most network cameras offer. |
My repo with support AVI is available to clone and test out. I've added an option to Misc in the demo to pick any user file off the device. What is working:
Not working:
Not supported yet:
https://github.com/dburckh/ExoPlayer If you find an issue, you can report it and I'll try to fix it. Please have a link available so I can download the file. |
Just added MJPEG support updated prior comment. Going to start writing tests! |
@dburckh Amazing work! Could you please enable Issues section in your GitHub fork so we can discuss issues there? I still need to verify some exception I got but I don't want to spam this thread. Thank you once again! |
Done. Make sure you get me a link to a sample. |
Great work! I know two guys that work on an AVI extractor, too. I've sent them a link to your repo. They have some issues but got a very good understanding of the AVI format, so I assume working together would speed things up a lot. |
So, the only things I have left on my TODO list are tests and maybe openDML. If there are feature requests or bugs, let me know. I suspect there will be some FourCC variants that I don't have, but those are a quick fix (@moneytoo already found one). |
There is a PR up for the ExoPlayer team now. I assume they will request some changes, but hopefully they will accept it in one form or another. FYI: I changed the branch to "avi" |
Google asked me to just put the AVI changes in my first PR, so moved the MJPEG and Demo changes into a branch called "everything" and made it default. |
@AquilesCanta has been looking at adding AVI support, and can probably provide an update here. |
Initial support is ready and will be released soon. But as explained in #9915, support is incomplete and we'll need support from the community to report (and ideally send PRs for) any issues you encounter. For those, please file fresh issues. EDIT: AVI support exists in the dev branch. |
Is it possible to play .avi format on ExoPlayer 2.0.
Due to FrameworkSampleSource are removed, are there any other way to play it?
The text was updated successfully, but these errors were encountered: