Skip to content

Commit

Permalink
Add lint base xml file for string.xml files
Browse files Browse the repository at this point in the history
Fixing lint errors in the string.xml files makes no sense because these are
overridden with the next automated string import. Adding a lint-baseline.xml
instead for the ui module.

See https://issuetracker.google.com/208178382

#minor-release

PiperOrigin-RevId: 455354304
  • Loading branch information
marcbaechinger committed Jun 16, 2022
1 parent 209d308 commit 495480a
Show file tree
Hide file tree
Showing 2 changed files with 68 additions and 0 deletions.
6 changes: 6 additions & 0 deletions library/ui/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@ apply from: "$gradle.ext.exoplayerSettingsDir/common_library_config.gradle"

android.buildTypes.debug.testCoverageEnabled true

android {
lint {
baseline = file("lint-baseline.xml")
}
}

dependencies {
implementation project(modulePrefix + 'library-common')
api 'androidx.media:media:' + androidxMediaVersion
Expand Down
62 changes: 62 additions & 0 deletions library/ui/lint-baseline.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- Copyright (C) 2022 The Android Open Source Project
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<issues format="6" by="lint 7.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (7.2.1)" variant="all" version="7.2.1">

<issue
id="MissingQuantity"
message="For locale &quot;fr&quot; (French) the following quantities should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;exo_controls_rewind_by_amount_description&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-fr-rCA/strings.xml"
line="31"
column="3"/>
</issue>

<issue
id="MissingQuantity"
message="For locale &quot;fr&quot; (French) the following quantities should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;exo_controls_rewind_by_amount_description&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-fr/strings.xml"
line="31"
column="3"/>
</issue>

<issue
id="MissingQuantity"
message="For locale &quot;fr&quot; (French) the following quantities should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;exo_controls_fastforward_by_amount_description&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-fr-rCA/strings.xml"
line="36"
column="3"/>
</issue>

<issue
id="MissingQuantity"
message="For locale &quot;fr&quot; (French) the following quantities should also be defined: `many`"
errorLine1=" &lt;plurals name=&quot;exo_controls_fastforward_by_amount_description&quot;>"
errorLine2=" ^">
<location
file="src/main/res/values-fr/strings.xml"
line="36"
column="3"/>
</issue>

</issues>

0 comments on commit 495480a

Please sign in to comment.