Defer outputting the metadata sample when TimestampAdjuster isn't ini…

…tialized

The sample timestamp carried by the emsg box can have a significant delta when comparing to the earliest presentation timestamp of the segment. Using this timestamp to intialize the timestamp offset in TimestampAdjuster will cause the media sample to have a wrong adjusted timestamp. So we should defer adjusting the metadata sample timestamp until the TimestampAdjuster is initialized with a real media sample.

PiperOrigin-RevId: 538172841

library/common/src/main/java/com/google/android/exoplayer2/util/TimestampAdjuster.java

@@ -105,14 +105,13 @@ public TimestampAdjuster(long firstSampleTimestampUs) {
   public synchronized void sharedInitializeOrWait(boolean canInitialize, long nextSampleTimestampUs)
       throws InterruptedException {
     Assertions.checkState(firstSampleTimestampUs == MODE_SHARED);
-    if (timestampOffsetUs != C.TIME_UNSET) {
-      // Already initialized.
+    if (isInitialized()) {
       return;
     } else if (canInitialize) {
       this.nextSampleTimestampUs.set(nextSampleTimestampUs);
     } else {
       // Wait for another calling thread to complete initialization.
-      while (timestampOffsetUs == C.TIME_UNSET) {
+      while (!isInitialized()) {
         wait();
       }
     }
@@ -194,7 +193,7 @@ public synchronized long adjustSampleTimestamp(long timeUs) {
     if (timeUs == C.TIME_UNSET) {
       return C.TIME_UNSET;
     }
-    if (timestampOffsetUs == C.TIME_UNSET) {
+    if (!isInitialized()) {
       long desiredSampleTimestampUs =
           firstSampleTimestampUs == MODE_SHARED
               ? Assertions.checkNotNull(nextSampleTimestampUs.get())
@@ -207,6 +206,11 @@ public synchronized long adjustSampleTimestamp(long timeUs) {
     return timeUs + timestampOffsetUs;
   }
 
+  /** Returns whether the instance is initialized with a timestamp offset. */
+  public synchronized boolean isInitialized() {
+    return timestampOffsetUs != C.TIME_UNSET;
+  }
+
   /**
    * Converts a 90 kHz clock timestamp to a timestamp in microseconds.
    *

library/extractor/src/main/java/com/google/android/exoplayer2/extractor/mp4/FragmentedMp4Extractor.java

@@ -681,6 +681,13 @@ private void onEmsgLeafAtomRead(ParsableByteArray atom) {
       pendingMetadataSampleInfos.addLast(
           new MetadataSampleInfo(sampleTimeUs, /* sampleTimeIsRelative= */ false, sampleSize));
       pendingMetadataSampleBytes += sampleSize;
+    } else if (timestampAdjuster != null && !timestampAdjuster.isInitialized()) {
+      // We also need to defer outputting metadata if the timestampAdjuster is not initialized,
+      // else we will set a wrong timestampOffsetUs in timestampAdjuster. See:
+      // https://github.com/androidx/media/issues/356.
+      pendingMetadataSampleInfos.addLast(
+          new MetadataSampleInfo(sampleTimeUs, /* sampleTimeIsRelative= */ false, sampleSize));
+      pendingMetadataSampleBytes += sampleSize;
     } else {
       // We can output the sample metadata immediately.
       if (timestampAdjuster != null) {