Skip to content

Commit

Permalink
Use golden bitmaps in contrast pixel tests.
Browse files Browse the repository at this point in the history 
PiperOrigin-RevId: 475805421
  • Loading branch information
@leonwind @marcbaechinger
leonwind authored and marcbaechinger committed Oct 19, 2022
1 parent 6015f05 commit 06c0040
Show file tree
Hide file tree
Showing 6 changed files with 30 additions and 56 deletions.
86 changes: 30 additions & 56 deletions ...media/libraries/effect/src/androidTest/java/androidx/media3/effect/ContrastPixelTest.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,14 @@
*/
@RunWith(AndroidJUnit4.class)
public class ContrastPixelTest {
private static final String EXOPLAYER_LOGO_PNG_ASSET_PATH =
"media/bitmap/exoplayer_logo/original.png";
private static final String MAXIMUM_CONTRAST_PNG_ASSET_PATH =
"media/bitmap/exoplayer_logo/maximum_contrast.png";
public static final String ORIGINAL_PNG_ASSET_PATH =
"media/bitmap/sample_mp4_first_frame/original.png";
public static final String INCREASE_CONTRAST_PNG_ASSET_PATH =
"media/bitmap/sample_mp4_first_frame/increase_contrast.png";
public static final String DECREASE_CONTRAST_PNG_ASSET_PATH =
"media/bitmap/sample_mp4_first_frame/decrease_contrast.png";
public static final String MAXIMUM_CONTRAST_PNG_ASSET_PATH =
"media/bitmap/sample_mp4_first_frame/maximum_contrast.png";

// OpenGL uses floats in [0, 1] and maps 0.5f to 128 = 256 / 2.
private static final int OPENGL_NEUTRAL_RGB_VALUE = 128;
Expand All @@ -71,7 +75,7 @@ public void createGlObjects() throws Exception {
eglDisplay = GlUtil.createEglDisplay();
eglContext = GlUtil.createEglContext(eglDisplay);

Bitmap inputBitmap = BitmapTestUtil.readBitmap(EXOPLAYER_LOGO_PNG_ASSET_PATH);
Bitmap inputBitmap = BitmapTestUtil.readBitmap(ORIGINAL_PNG_ASSET_PATH);
inputWidth = inputBitmap.getWidth();
inputHeight = inputBitmap.getHeight();

Expand All @@ -95,14 +99,15 @@ public void drawFrame_noContrastChange_leavesFrameUnchanged() throws Exception {
new Contrast(/* contrast= */ 0.0f).toGlTextureProcessor(context, /* useHdr= */ false);
Pair<Integer, Integer> outputSize = contrastProcessor.configure(inputWidth, inputHeight);
setupOutputTexture(outputSize.first, outputSize.second);
Bitmap expectedBitmap = BitmapTestUtil.readBitmap(EXOPLAYER_LOGO_PNG_ASSET_PATH);
Bitmap expectedBitmap = BitmapTestUtil.readBitmap(ORIGINAL_PNG_ASSET_PATH);

contrastProcessor.drawFrame(inputTexId, /* presentationTimeUs = */ 0);
Bitmap actualBitmap =
BitmapTestUtil.createArgb8888BitmapFromCurrentGlFramebuffer(
outputSize.first, outputSize.second);

BitmapTestUtil.maybeSaveTestBitmapToCacheDirectory(testId, "actual", actualBitmap);
BitmapTestUtil.maybeSaveTestBitmapToCacheDirectory(
testId, /* bitmapLabel= */ "actual", actualBitmap);
float averagePixelAbsoluteDifference =
BitmapTestUtil.getAveragePixelAbsoluteDifferenceArgb8888(
expectedBitmap, actualBitmap, testId);
Expand All @@ -128,7 +133,8 @@ public void drawFrame_minimumContrast_producesAllGrayFrame() throws Exception {
BitmapTestUtil.createArgb8888BitmapFromCurrentGlFramebuffer(
outputSize.first, outputSize.second);

BitmapTestUtil.maybeSaveTestBitmapToCacheDirectory(testId, "actual", actualBitmap);
BitmapTestUtil.maybeSaveTestBitmapToCacheDirectory(
testId, /* bitmapLabel= */ "actual", actualBitmap);
float averagePixelAbsoluteDifference =
BitmapTestUtil.getAveragePixelAbsoluteDifferenceArgb8888(
expectedBitmap, actualBitmap, testId);
Expand All @@ -143,15 +149,19 @@ public void drawFrame_decreaseContrast_decreasesPixelsGreaterEqual128IncreasesBe
new Contrast(/* contrast= */ -0.75f).toGlTextureProcessor(context, /* useHdr= */ false);
Pair<Integer, Integer> outputSize = contrastProcessor.configure(inputWidth, inputHeight);
setupOutputTexture(outputSize.first, outputSize.second);
Bitmap originalBitmap = BitmapTestUtil.readBitmap(EXOPLAYER_LOGO_PNG_ASSET_PATH);
Bitmap expectedBitmap = BitmapTestUtil.readBitmap(DECREASE_CONTRAST_PNG_ASSET_PATH);

contrastProcessor.drawFrame(inputTexId, /* presentationTimeUs= */ 0);
Bitmap actualBitmap =
BitmapTestUtil.createArgb8888BitmapFromCurrentGlFramebuffer(
outputSize.first, outputSize.second);

BitmapTestUtil.maybeSaveTestBitmapToCacheDirectory(testId, "actual", actualBitmap);
assertIncreasedOrDecreasedContrast(originalBitmap, actualBitmap, /* increased= */ false);
BitmapTestUtil.maybeSaveTestBitmapToCacheDirectory(
testId, /* bitmapLabel= */ "actual", actualBitmap);
float averagePixelAbsoluteDifference =
BitmapTestUtil.getAveragePixelAbsoluteDifferenceArgb8888(
expectedBitmap, actualBitmap, testId);
assertThat(averagePixelAbsoluteDifference).isAtMost(MAXIMUM_AVERAGE_PIXEL_ABSOLUTE_DIFFERENCE);
}

@Test
Expand All @@ -162,15 +172,19 @@ public void drawFrame_increaseContrast_increasesPixelsGreaterEqual128DecreasesBe
new Contrast(/* contrast= */ 0.75f).toGlTextureProcessor(context, /* useHdr= */ false);
Pair<Integer, Integer> outputSize = contrastProcessor.configure(inputWidth, inputHeight);
setupOutputTexture(outputSize.first, outputSize.second);
Bitmap originalBitmap = BitmapTestUtil.readBitmap(EXOPLAYER_LOGO_PNG_ASSET_PATH);
Bitmap expectedBitmap = BitmapTestUtil.readBitmap(INCREASE_CONTRAST_PNG_ASSET_PATH);

contrastProcessor.drawFrame(inputTexId, /* presentationTimeUs= */ 0);
Bitmap actualBitmap =
BitmapTestUtil.createArgb8888BitmapFromCurrentGlFramebuffer(
outputSize.first, outputSize.second);

BitmapTestUtil.maybeSaveTestBitmapToCacheDirectory(testId, "actual", actualBitmap);
assertIncreasedOrDecreasedContrast(originalBitmap, actualBitmap, /* increased= */ true);
BitmapTestUtil.maybeSaveTestBitmapToCacheDirectory(
testId, /* bitmapLabel= */ "actual", actualBitmap);
float averagePixelAbsoluteDifference =
BitmapTestUtil.getAveragePixelAbsoluteDifferenceArgb8888(
expectedBitmap, actualBitmap, testId);
assertThat(averagePixelAbsoluteDifference).isAtMost(MAXIMUM_AVERAGE_PIXEL_ABSOLUTE_DIFFERENCE);
}

@Test
Expand All @@ -187,54 +201,14 @@ public void drawFrame_maximumContrast_pixelEither0or255() throws Exception {
BitmapTestUtil.createArgb8888BitmapFromCurrentGlFramebuffer(
outputSize.first, outputSize.second);

BitmapTestUtil.maybeSaveTestBitmapToCacheDirectory(testId, "actual", actualBitmap);
BitmapTestUtil.maybeSaveTestBitmapToCacheDirectory(
testId, /* bitmapLabel= */ "actual", actualBitmap);
float averagePixelAbsoluteDifference =
BitmapTestUtil.getAveragePixelAbsoluteDifferenceArgb8888(
expectedBitmap, actualBitmap, testId);
assertThat(averagePixelAbsoluteDifference).isAtMost(MAXIMUM_AVERAGE_PIXEL_ABSOLUTE_DIFFERENCE);
}

private static void assertIncreasedOrDecreasedContrast(
Bitmap originalBitmap, Bitmap actualBitmap, boolean increased) {

for (int y = 0; y < actualBitmap.getHeight(); y++) {
for (int x = 0; x < actualBitmap.getWidth(); x++) {
int originalColor = originalBitmap.getPixel(x, y);
int actualColor = actualBitmap.getPixel(x, y);

int redDifference = Color.red(actualColor) - Color.red(originalColor);
int greenDifference = Color.green(actualColor) - Color.green(originalColor);
int blueDifference = Color.blue(actualColor) - Color.blue(originalColor);

// If the contrast increases, all pixels with a value greater or equal to
// OPENGL_NEUTRAL_RGB_VALUE must increase (diff is greater or equal to 0) and all pixels
// below OPENGL_NEUTRAL_RGB_VALUE must decrease (diff is smaller or equal to 0).
// If the contrast decreases, all pixels with a value greater or equal to
// OPENGL_NEUTRAL_RGB_VALUE must decrease (diff is smaller or equal to 0) and all pixels
// below OPENGL_NEUTRAL_RGB_VALUE must increase (diff is greater or equal to 0).
// The interval limits 0 and 255 stay unchanged for either contrast in- or decrease.

if (Color.red(originalColor) >= OPENGL_NEUTRAL_RGB_VALUE) {
assertThat(increased ? redDifference : -redDifference).isAtLeast(0);
} else {
assertThat(increased ? redDifference : -redDifference).isAtMost(0);
}

if (Color.green(originalColor) >= OPENGL_NEUTRAL_RGB_VALUE) {
assertThat(increased ? greenDifference : -greenDifference).isAtLeast(0);
} else {
assertThat(increased ? greenDifference : -greenDifference).isAtMost(0);
}

if (Color.blue(originalColor) >= OPENGL_NEUTRAL_RGB_VALUE) {
assertThat(increased ? blueDifference : -blueDifference).isAtLeast(0);
} else {
assertThat(increased ? blueDifference : -blueDifference).isAtMost(0);
}
}
}
}

private void setupOutputTexture(int outputWidth, int outputHeight) throws GlUtil.GlException {
outputTexId =
GlUtil.createTexture(
Expand Down
Binary file removed testdata/src/test/assets/media/bitmap/exoplayer_logo/maximum_contrast.png
View file
Binary file not shown.
Binary file removed testdata/src/test/assets/media/bitmap/exoplayer_logo/original.png
View file
Binary file not shown.
Binary file added testdata/src/test/assets/media/bitmap/sample_mp4_first_frame/decrease_contrast.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added testdata/src/test/assets/media/bitmap/sample_mp4_first_frame/increase_contrast.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added testdata/src/test/assets/media/bitmap/sample_mp4_first_frame/maximum_contrast.png
View file
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 06c0040

Please sign in to comment.