-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in instruction_following_eval #1847
Comments
And by the way: These two methods(( |
just noticed the same. it seems that the if isinstance(instruction, instructions.RepeatPromptThenAnswer):
instruction.build_description(prompt_to_repeat=inp.prompt.split("\n")[0],**inp.kwargs[index])
else:
instruction.build_description(**inp.kwargs[index]) .. in |
Sorry. There's a stupid bug. The prompt set is wrong. Fix coming in within 12 hours. |
Hi all, |
@lehougoogle
Thank you for your excellent work on the instruction-following ability. However, I've noticed a bug in your code.
In the build_description method within your code, specifically when handling the
Instruction
typeRepeatPromptThenAnswer
, a parameter namedprompt_to_repeat
is required. However, I observed that in your kwargs, this parameter is missing.Although there is an attempt to address this issue through this line, it seems there's a mismatch in the parameter name (
prompt_to_repeat
should be used instead ofprompt
).I managed to resolve this issue in my implementation with the following code:
The text was updated successfully, but these errors were encountered: