Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover Github hostname from the context to support the Github Enterprise Server #17

Closed
tvishwanatharkin opened this issue Jul 26, 2024 · 0 comments · Fixed by #19
Closed

Discover Github hostname from the context to support the Github Enterprise Server #17

tvishwanatharkin opened this issue Jul 26, 2024 · 0 comments · Fixed by #19
Assignees
@sailorlqh
Labels
enhancement New feature or request

Comments

@tvishwanatharkin
Copy link

tvishwanatharkin commented Jul 26, 2024 •
edited
Loading

TL;DR

In the message payload, click_url for Open Workflow button assumes that the host is always github.com, making it hard for teams using Github Enterprise Server.

Detailed design

Hardcoding github.com in URL formation of Open workflow button makes it hard of of It's always good to discover the github host from the workflownotification itself. Github context contains the Host URL in server_url field.
This allows teams running the Github Enterprise Server onpremise consume this action.

Additional information

No response
@tvishwanatharkin tvishwanatharkin added the enhancement New feature or request label Jul 26, 2024
@tvishwanatharkin tvishwanatharkin changed the title Discover Github hostname from the workflownotification to support the Github Enterprise Server Discover Github hostname from the context to support the Github Enterprise Server Jul 26, 2024
@sailorlqh sailorlqh mentioned this issue Oct 30, 2024
Merged
sailorlqh added a commit that referenced this issue Oct 30, 2024
@sailorlqh
feat: Get server url from github context (#19)
2173622 
fixes: #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sailorlqh sailorlqh

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Get server url from github context google-github-actions/send-google-chat-webhook
2 participants
@tvishwanatharkin @sailorlqh