Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GenerationConfig to match the API. #609

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Fix GenerationConfig to match the API. #609

merged 2 commits into from
Oct 24, 2024

Conversation

MarkDaoust
Copy link
Collaborator

No description provided.

@MarkDaoust
Fix GenerationConfig, this doesn't match the API
b9a965e 
Change-Id: I4e0c3b45125023e056c3d7e1549eafb47e42815a
@MarkDaoust MarkDaoust marked this pull request as draft October 17, 2024 21:35
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Oct 17, 2024
@MarkDaoust MarkDaoust mentioned this pull request Oct 17, 2024
Closed
@MarkDaoust
format
6f8557e 
Change-Id: I161dd7b9b371e005b4385faeaa84f6d141e09b43
@MarkDaoust MarkDaoust marked this pull request as ready for review October 17, 2024 21:44
markmcd
markmcd approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but did we end up keeping logprobs in the API? I won't auto-merge as I don't really know what happened ultimately but don't let me block you if you know what's going on :)

@MarkDaoust MarkDaoust marked this pull request as draft October 24, 2024 17:32
@MarkDaoust
Copy link
Collaborator Author

b/373654852

@MarkDaoust MarkDaoust marked this pull request as ready for review October 24, 2024 17:42
@MarkDaoust MarkDaoust merged commit 3d91916 into google-gemini:main Oct 24, 2024
10 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmcd markmcd markmcd approved these changes

@BariRafsan BariRafsan BariRafsan approved these changes

@shilpakancharla shilpakancharla Awaiting requested review from shilpakancharla

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkDaoust @markmcd @BariRafsan