-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stream file upload #556
Merged
MarkDaoust
merged 8 commits into
google-gemini:main
from
Hamza-nabil:stream-file-upload
Sep 27, 2024
Merged
Stream file upload #556
MarkDaoust
merged 8 commits into
google-gemini:main
from
Hamza-nabil:stream-file-upload
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Change-Id: I346da140eef00d5fca595255ef8926079cada6a6
Change-Id: Iea071c396c4cfe2b2c8eacae74dd8fb0acbc128f
Hamza-nabil
commented
Sep 27, 2024
Change-Id: I572f02ed98b9ca45299b76e7a01695fdcf917e1e
…enerative-ai-python into stream-file-upload Change-Id: Ib1a9ffcbad13ddecaca2350850101e7c0b74840a
LGTM Thank you! Oops, thanks for the fix! |
MarkDaoust
previously approved these changes
Sep 27, 2024
Change-Id: I220c05eee73ae76ced25254d67332f70a4069f7e
MarkDaoust
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Add support for streaming file uploads in the
upload_file
function.The table below outlines the expected behavior for handling
IOBase
instances compared toPath
instances:IOBase
instancePath
instanceMediaIoBaseUpload
MediaFileUpload
'application/octet-stream'
(reference here)None
path.name
Motivation
This update addresses #537, which requests the addition of support for uploading files via stream
Type of change
Feature request
Checklist
git pull --rebase upstream main
).