Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Count tokens #315

Merged
merged 4 commits into from
May 3, 2024
Merged

Count tokens #315

merged 4 commits into from
May 3, 2024

Conversation

MarkDaoust
Copy link
Collaborator

  • Expand the arguments to count_tokens to cover the full GenerateContentRequest.
  • Update GenerateContentResponse to handle usage_metadata and candidate token counts.
  • Add indentation to the json in the str or GenerateContentResponse

MarkDaoust added 2 commits May 2, 2024 13:11
@MarkDaoust
Upgrade count tokens, add usage metadata.
35854cc 
Change-Id: Ib07580b4f22db7e7c58109d6d0c8a27076f204da
@MarkDaoust
Fix usage_metadata for streaming, fix indentation in __str__.
c0401ba 
Change-Id: I08ceb067355c933c20d50beb8ee51f9e7ba83ee7
@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels May 2, 2024
MarkDaoust added 2 commits May 2, 2024 16:00
@MarkDaoust
format
8d2a9ac 
Change-Id: I11ed2499b974d7cacde88c740386a5f9a71186ea
@MarkDaoust
fix typing
f958c3c 
Change-Id: Ieeae7eefebc330a4b856b0016912f4fce509d780
@shilpakancharla shilpakancharla merged commit c165b20 into google-gemini:main May 3, 2024
7 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label May 3, 2024
@MarkDaoust MarkDaoust mentioned this pull request May 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilpakancharla shilpakancharla shilpakancharla approved these changes

Assignees
No one assigned
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkDaoust @shilpakancharla