Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

Commit

Permalink
Merge pull request #253 from google-fabric/transition-timeout
Browse files Browse the repository at this point in the history
Adds a timeout prop to Transition in test
  • Loading branch information
fionawhim authored May 9, 2019
2 parents 5815dbf + 1cf7ab5 commit de6ba6f
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
### v1.4.3 (2019-05-09):

Adds `timeout` prop to `Transition` in test to avoid a PropTypes warning.

### v1.4.2 (2018-11-14):

Uses a `<Transition>` element in test/server mode to keep react-dom from warning
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "velocity-react",
"version": "1.4.2",
"version": "1.4.3",
"description": "React components to wrap Velocity animations",
"main": "index.js",
"scripts": {
Expand Down
3 changes: 2 additions & 1 deletion src/velocity-transition-group.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,8 @@ class VelocityTransitionGroup extends React.Component {
// Wrapping in a no-op Transition to consume the props that
// TransitionGroup gives its children. Fixes react-dom warnings
// in test for those props appearing on divs and such.
child => child && React.createElement(Transition, {}, child)
child =>
child && React.createElement(Transition, { timeout: 0 }, child)
)
);
}
Expand Down

0 comments on commit de6ba6f

Please sign in to comment.