Updating API to include the union types for mjuiItem #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous command cannot find include of other files and errors. This specifically misses some of the type union struct defintions.
Required to generate the API for mjuiItem, otherwise the struct information itself is not discovered.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changed the docs for running the clang command to generate the AST, as this errored without the include directory. I am not sure if this is the command that should be used, but it does not encounter any errors.
The chain change is modifying the header file
mjui.hto add typedefs for the structs used bymjuiItemso that they can be discovered and generated by theintrospectmodule.@yuvaltassa @saran-t I noticed that these typedefs were missing when I was writing code to base our Julia API on your
introspectmodule. Also many thanks for your advice pointing us towards this module, it's incredibly helpful.