Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up continuous integration #1

Closed
nimrod-gileadi opened this issue Oct 18, 2021 · 1 comment
Closed

Set up continuous integration #1

nimrod-gileadi opened this issue Oct 18, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@nimrod-gileadi
Copy link
Collaborator

We would like to run some unit and integration tests continuously once we have the source code on github.

We'll probably use GitHub Actions for this, and would like to build and test on Linux, Windows, macOS.
@saran-t saran-t added the enhancement New feature or request label Oct 18, 2021
@saran-t
Copy link
Member

saran-t commented May 23, 2022

GitHub Actions is now live on this repo, however the Python bindings are not included in the workflow yet.

@saran-t saran-t closed this as completed May 23, 2022
liuliu added a commit to liuliu/mujoco that referenced this issue Jun 7, 2022
@liuliu
Fix two asan detected memory bugs
f748018 
I am running through simulate.swift (my port of simulate.cc) with
address sanitizer to discover related bugs.

Besides ones in my port, there are two in MuJoCo:

1. in maketext, the logic to find . is not protected against j is less
   than 0 (due to the decreasing logic above), creating out of bound
   access.

2. in mj_printFormattedData, qfrc_applied should use length nv not nq,
   otherwise out of bound access could be triggered.

Test Plan:

Run through the simulate.cc with asan. Before this fix, when presenting
profiler view, it will trigger bug google-deepmind#1. When print data, it will trigger
bug google-deepmind#2. Both are using model/humanoid/22_humanoids.xml.
@liuliu liuliu mentioned this issue Jun 7, 2022
Merged
@zhihaocheng zhihaocheng mentioned this issue Jun 18, 2022
Closed
@songdaegeun songdaegeun mentioned this issue May 1, 2024
Closed
@PeterOGB PeterOGB mentioned this issue Oct 3, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saran-t @nimrod-gileadi