This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Fix getattr #49
Open
Fix getattr #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 456253157 Change-Id: Ic71f175da32c83fd949acf0f385c4e045a0ea746
PiperOrigin-RevId: 473376926 Change-Id: Iea794a3e13d274a5694b9762c405cbae3db7cd82
…claimed in the colab. PiperOrigin-RevId: 479005894 Change-Id: I7418926eae648651deb6971863957cdb682caf14
This change replaces references to a number of deprecated NumPy type aliases (np.bool, np.int, np.float, np.complex, np.object, np.str) with their recommended replacement (bool, int, float, complex, object, str). NumPy 1.24 drops the deprecated aliases, so we must remove uses before updating NumPy. PiperOrigin-RevId: 496609197 Change-Id: I3520b3fe132a37119a0a1949a9a92e3426499607
PiperOrigin-RevId: 511422304 Change-Id: I8945990f1c970037d16d3456be0063acb91266ee
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
__getattr__methods in the wrappers to also check if the underlying environments have the attribute called.